[ASan][Compiler-rt] Support Gracefull hsa-runtime shutdown. #559
+152
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Collaborator
ampandey-AMD
force-pushed
the
fix-swdev-519413-mi300
branch
from
84f2839 to
4e6a327
Compare
Collaborator
ampandey-AMD
force-pushed
the
fix-swdev-519413-mi300
branch
from
4e6a327 to
02dccdb
Compare
Collaborator
ampandey-AMD
force-pushed
the
fix-swdev-519413-mi300
branch
2 times, most recently
from
fc9cd0d to
b78dbb5
Compare
Collaborator
Collaborator
Collaborator
Collaborator
ampandey-AMD
force-pushed
the
fix-swdev-519413-mi300
branch
from
d41eca8 to
78e3a56
Compare
Collaborator
b-sumner
reviewed
Dec 1, 2025
b-sumner
reviewed
Dec 1, 2025
compiler-rt/lib/sanitizer_common/sanitizer_allocator_amdgpu.cpp
Outdated
Show resolved
Hide resolved
ampandey-AMD
force-pushed
the
fix-swdev-519413-mi300
branch
from
78e3a56 to
e8ae56c
Compare
Collaborator
ampandey-AMD
force-pushed
the
fix-swdev-519413-mi300
branch
from
e8ae56c to
894289b
Compare
Collaborator
b-sumner
reviewed
Dec 2, 2025
ampandey-AMD
force-pushed
the
fix-swdev-519413-mi300
branch
from
894289b to
d9c4492
Compare
Collaborator
Summary:
- Track runtime shutdown via AmdgpuMemFuncs::IsAmdgpuRuntimeShutdown()
and gate further hsa_amd_pointer_info calls.
- Add interception of 'hsa_init' api call.
- Add registration of hsa-runtime associated system events via
'hsa_amd_register_system_event_handler'.
- HSA event registered is 'HSA_AMD_SYSTEM_SHUTDOWN_EVENT'
Summary: - Added wrapper IsAmdgpuRuntimeShutdown for checking state. - Added wrapper NotifyAmdgpuRuntimeShutdown for updating state.
- Add verbose logging logic. - Refactor AmdgpuMemFuncs::Init function. - Add CAS check for AMDGPU shutdown callback registering.
ampandey-AMD
force-pushed
the
fix-swdev-519413-mi300
branch
from
afdf142 to
5fefd6d
Compare
Collaborator
ampandey-AMD
force-pushed
the
fix-swdev-519413-mi300
branch
from
993355c to
5fefd6d
Compare
Collaborator
Collaborator
b-sumner
reviewed
Dec 5, 2025
| void *AmdgpuMemFuncs::Allocate(uptr size, uptr alignment, | ||
| DeviceAllocationInfo *da_info) { | ||
| // Do not allocate if AMDGPU runtime is shutdown | ||
| if (IsAmdgpuRuntimeShutdown()) { |
Collaborator
There was a problem hiding this comment.
Should we use UNLIKELY here?
|
|
||
| void AmdgpuMemFuncs::Deallocate(void *p) { | ||
| // Deallocate does nothing after AMDGPU runtime shutdown | ||
| if (IsAmdgpuRuntimeShutdown()) { |
Collaborator
There was a problem hiding this comment.
Should we use UNLIKELY here?
|
|
||
| bool AmdgpuMemFuncs::GetPointerInfo(uptr ptr, DevicePointerInfo* ptr_info) { | ||
| // GetPointerInfo returns false after AMDGPU runtime shutdown | ||
| if (IsAmdgpuRuntimeShutdown()) { |
Collaborator
There was a problem hiding this comment.
Should we use UNLIKELY here?
| CHECK_LT(idx, n_chunks_); | ||
| h = GetHeader(chunks_[idx], &header); | ||
| CHECK(!dev_runtime_unloaded_); | ||
| if (dev_runtime_unloaded_) |
Collaborator
There was a problem hiding this comment.
Should we use UNLIKELY here?
| for (uptr i = 0; i < n_chunks_; i++) { | ||
| Header *h = GetHeader(chunks_[i], &header); | ||
| CHECK(!dev_runtime_unloaded_); | ||
| if (dev_runtime_unloaded_) |
Collaborator
There was a problem hiding this comment.
Should we use UNLIKELY here?
| // Device allocator has dependency on device runtime. If device runtime | ||
| // is unloaded, GetPointerInfo() will fail. For such case, we can still | ||
| // return a valid value for map_beg, map_size will be limited to one page | ||
| if (!dev_runtime_unloaded_) { |
Collaborator
There was a problem hiding this comment.
Should we instead make an UNLIKELY check for unloaded here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
and gate further hsa_amd_pointer_info calls.
'hsa_amd_register_system_event_handler'.